Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6216] Unify SQL naming style. #6239

Merged
merged 4 commits into from
Jul 5, 2021
Merged

[ISSUE #6216] Unify SQL naming style. #6239

merged 4 commits into from
Jul 5, 2021

Conversation

mask616
Copy link
Contributor

@mask616 mask616 commented Jul 1, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For [#6216]

Unify SQL naming style.

Naming rules:

SQL keyword : uppercase(eg.INSERT INTO, SELECT, UPDATE, DELETE, FROM, WHERE, LEFT JOIN, AND, LIKE... )
SQL function name : lowercase(eg. count, max...)
SQL field name: lowercase
Table name : lowercase

For example:

SELECT a,b,c FROM table;
SELECT count(*) FROM table;

@KomachiSion
Copy link
Collaborator

Is this PR duplicated with #6233

@mask616
Copy link
Contributor Author

mask616 commented Jul 2, 2021

#6233

No, #6233 just modified the naming of some java source files SQL. This PR unifies the naming of all Java source files SQL in the config module. In addition, I also provide naming rules.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the count is modified by other PR to upper case.

And all of them are modified to lower case.

Should we unify al of them?

@mask616
Copy link
Contributor Author

mask616 commented Jul 2, 2021

I found that the count is modified by other PR to upper case.

And all of them are modified to lower case.

Should we unify al of them?

Now, all the count is lower case.
I used the full-text search keyword 'COUNT' and didn't find the uppercase 'COUNT'

@mask616 mask616 requested a review from KomachiSion July 2, 2021 16:20
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 5, 2021
@KomachiSion KomachiSion merged commit 5aab426 into alibaba:develop Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants