Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue #6284][naming module] replace *commons.lang3*.*Utils to com.al… #6291

Merged
merged 4 commits into from
Jul 12, 2021

Conversation

ZZQ001010
Copy link
Contributor

for #6284

@@ -187,7 +187,7 @@ public ServiceInfo listInstance(String namespaceId, String serviceName, Subscrib
checkIfDisabled(service);

List<com.alibaba.nacos.naming.core.Instance> srvedIps = service
.srvIPs(Arrays.asList(StringUtils.split(cluster, ",")));
.srvIPs(Arrays.asList(cluster.split(",")));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether throw NPE?

@ZZQ001010 ZZQ001010 force-pushed the develop-issue#6284 branch from b6bec87 to 2566f85 Compare July 7, 2021 03:34
KomachiSion
KomachiSion previously approved these changes Jul 8, 2021
@KomachiSion KomachiSion merged commit 98e1e72 into alibaba:develop Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants