-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #9859] 重构默认插件的登陆/鉴权逻辑 #9889
[ISSUE #9859] 重构默认插件的登陆/鉴权逻辑 #9889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果这个PR完成了, 是不是可以吧spring-security去掉?
这玩意太多安全工程师盯着了, 容易出漏洞。
其实我尝试过移除spring-security, 但是发现移除了spring-security之后, console不能正常登陆了. |
6ca94c2
to
be3e294
Compare
be3e294
to
06372e8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #9889 +/- ##
=============================================
- Coverage 47.36% 47.08% -0.28%
+ Complexity 4513 4500 -13
=============================================
Files 861 865 +4
Lines 28001 28110 +109
Branches 3121 3132 +11
=============================================
- Hits 13263 13236 -27
- Misses 13536 13679 +143
+ Partials 1202 1195 -7
Continue to review full report at Codecov.
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
重构默认插件的登陆/鉴权逻辑, 提高性能.
Brief changelog
不使用
Spring-Security
中的登陆鉴权逻辑,由鉴权插件自己实现:Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.