-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the nacos-client/pom.xml
for exclude google/**/*.proto
#9982
Conversation
pom.xml
of the nacos-client
for exclude /META-INF/native-image/*
nacos-client/pom.xml
for exclude /META-INF/native-image/*
nacos-client/pom.xml
for exclude /META-INF/native-image/*
nacos-client/pom.xml
for exclude /META-INF/native-image/*
and *.proto
nacos-client/pom.xml
for exclude /META-INF/native-image/*
and *.proto
nacos-client/pom.xml
for exclude /META-INF/native-image/*
and google/**/*.proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great future ahead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use nacos code style to reformat code
the indent in this pr has problem
顺便问一下 native-image也移除掉会不会影响 java native(graalVM)的功能? |
需要时,应该去oracle仓库里加。之前和SCA那边沟通过,是说以后都统一去oracle仓库里提PR,而不是写在jar里。 |
另外,我本地排除掉后,也在native-image里试过,可以正常使用。 |
done |
另外,我仔细看了一下从 而 但是,我的PR里,还是得修改一下。排除掉 |
@KomachiSion 目前,可能是 shade 插件的配置有问题。 |
native-image是不是需要自己生成,直接shard应该不行? |
我觉得可以提个issue来讨论, PR先不提交。 讨论并测试清楚之后再提交。 我觉得这个natvie-image应该是jdk17的 graalVM所用到的, 不shard进去不影响普通的使用,但在graalVM中可能有影响。 |
我看了下grpc那边的源码,由于是gradle,不是maven,很多我看的不是很懂,但是应该是使用了shade插件的功能,自动补充了前缀。 |
嗯,可以的,那我这个PR先暂时只移除proto文件吧。 |
我另外提个issue |
nacos-client/pom.xml
for exclude /META-INF/native-image/*
and google/**/*.proto
nacos-client/pom.xml
for exclude google/**/*.proto
我测试过,不影响,因为shade进来的配置本来就是错的,包名和shaded进来的类名对不上。 |
这个PR已经好了,排除native-image的代码撤回了。 |
Optimize the
nacos-client/pom.xml
for excludegoogle/**/*.proto
nacos-client
的pom.xml
,用于排除掉google/**/*.proto
;同时,将shade插件在多个profile中的重复定义转移到
pluginManagement
中统一定义;maven-jar-plugin
的版本号,不添加时,打包会有WARNING信息;pom.xml
中,移除了不需要引用的依赖io.grpc:protoc-gen-grpc-java
,该依赖为pom类型,里面并没有定义任何dependenies信息,不需要依赖它。pom.xml
。See:
![图片](https://user-images.githubusercontent.com/1527893/220244513-2d935a40-147d-4835-8093-11452e4e7897.png)