When remove ephemeral csi failed, force remove it. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 32.10% 32.38% +0.28%
==========================================
Files 41 41
Lines 6411 6425 +14
==========================================
+ Hits 2058 2081 +23
+ Misses 4064 4054 -10
- Partials 289 290 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -224,13 +225,22 @@ func (ns *nodeServer) NodeUnpublishVolume(ctx context.Context, req *csi.NodeUnpu | |||
| } | |||
| } | |||
|
|
|||
| ephemeralDevice, exist := ns.ephemeralVolumeStore.GetDevice(volumeID) | |||
|
|
|||
| if err := ns.osTool.CleanupMountPoint(targetPath, ns.k8smounter, true /*extensiveMountPointCheck*/); err != nil { | |||
There was a problem hiding this comment.
What's the case of unmount failure, is the container still running?
VinceCui
force-pushed
the
force-remove-ephemeral-csi-if-fail
branch
from
bc41367
to
b3ed397
Compare
VinceCui
force-pushed
the
force-remove-ephemeral-csi-if-fail
branch
from
b3ed397
to
74e2ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.