-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reactive sentinel circuit breaker tests #3054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielLiu1123
approved these changes
Jan 6, 2023
steverao
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ruansheng8 Please create a same PR to other main branch.
This was referenced Jan 6, 2023
Closed
ruansheng8
added a commit
to ruansheng8/spring-cloud-alibaba
that referenced
this pull request
Jan 6, 2023
* Fix reactive sentinel circuit breaker tests
ruansheng8
added a commit
to ruansheng8/spring-cloud-alibaba
that referenced
this pull request
Jan 6, 2023
* Fix reactive sentinel circuit breaker tests
This was referenced Jan 6, 2023
steverao
pushed a commit
that referenced
this pull request
Jan 6, 2023
steverao
pushed a commit
that referenced
this pull request
Jan 6, 2023
ruansheng8
added a commit
to ruansheng8/spring-cloud-alibaba
that referenced
this pull request
Jan 6, 2023
* Fix reactive sentinel circuit breaker tests
steverao
pushed a commit
that referenced
this pull request
Jan 6, 2023
ruansheng8
added a commit
to ruansheng8/spring-cloud-alibaba
that referenced
this pull request
Jan 30, 2023
* Fix reactive sentinel circuit breaker tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
修复 Sentinel reactive 单元测试偶发不通过的情况 , 具体异常见:
https://github.com/alibaba/spring-cloud-alibaba/actions/runs/3845399772/jobs/6549501288
单元测试调用slow() 接口 , 每次调用延迟80ms
统计规则:
Unit test code:
修复方案:
减少循环时的等待时间 (1000ms -> 900ms) , 循环结束后等待500ms (补偿前面循环的等待时间 , 因为后面的单元测试需要在新的时间窗口中进行统计)