Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: deleted spring-cloud-alibaba-docs module #3490

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Docs: deleted spring-cloud-alibaba-docs module #3490

merged 2 commits into from
Dec 1, 2023

Conversation

yuluo-yx
Copy link
Collaborator

@yuluo-yx yuluo-yx commented Nov 8, 2023

Describe what this PR does / why we need it

@ruansheng8 ruansheng8 self-requested a review November 10, 2023 03:24
Copy link
Collaborator

@ruansheng8 ruansheng8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit the doc-url in the README.md file to the new doc-url.

@yuluo-yx
Copy link
Collaborator Author

Edit the doc-url in the README.md file to the new doc-url.

yep. In order to solve this problem, I added markdown error link detection. Maybe due to repo permissions, ci is not running properly. For details, please see: https://github.com/yuluo-yx/spring-cloud-alibaba/pull/1/checks
I will check every readme file later to make sure there are no bad links.

Copy link
Collaborator

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruansheng8 ruansheng8 merged commit 01e6981 into alibaba:2022.x Dec 1, 2023
3 checks passed
@ruansheng8
Copy link
Collaborator

LGTM

@yuluo-yx yuluo-yx deleted the 1108/deleted-sca-docs-module branch December 1, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants