Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(AnyResult): failure typehint is now also Any #63

Merged
merged 1 commit into from
Jun 20, 2023
Merged

chore(AnyResult): failure typehint is now also Any #63

merged 1 commit into from
Jun 20, 2023

Conversation

acostapazo
Copy link
Collaborator

No description provided.

@acostapazo
Copy link
Collaborator Author

AnyResult should not determine a specific typehint.

Now, in some use cases could cause some errors as: #15097 False positive when calling a method from a subclass

@fgsalomon
Copy link
Contributor

Should not we do the same with BoolResult?

@acostapazo
Copy link
Collaborator Author

Should not we do the same with BoolResult?

I don't know, AnyResult has a semantic content that justifies everything to be Any.

But the BoolResult is not clear to me whether it is semantically correct for the failure type to be so lax.

@acostapazo acostapazo merged commit db952bb into main Jun 20, 2023
@acostapazo acostapazo deleted the feature/any-result-also-in-failure-type branch June 20, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsalomon fgsalomon fgsalomon approved these changes

@miguel-lorenzo miguel-lorenzo Awaiting requested review from miguel-lorenzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acostapazo @fgsalomon