Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid superposition of bloch sphere in the tree #15

Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix: avoid superposition of bloch sphere in the tree #15

merged 2 commits into from
Jan 23, 2023

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Jan 22, 2023

Fix #14

Plotting analysis

I set the background of the tree figure to blue and the spheres in red to better understand what we were looking at:

Capture d’écran 2023-01-22 à 23 08 32

What we see is:

  • the sphere squares are overlapping on each other
  • the top [0> is cut by the subplot

solution

for single display (separate calls to bloch_points) I left everything as it is. my logic being: there is no overlapping when there is just 1 sphere.

For tree I left the default background of the fig (transparent/white depending on the env) and set the background of the sphere axes to transparent white. By doing so we don't see the overlapping anymore.

before after

Bonus

  • moved the badges in the example section to look nicer in colab
  • modified the image in the readme to use the one with transparent background

PS

@alice4space, I left the PR in draft state so that you get the PR -> review -> merge system. Once you will approve my PR I will turn it "ready for review" and you'll be able to merge it

@12rambau 12rambau marked this pull request as draft January 22, 2023 22:37
@alice4space alice4space marked this pull request as ready for review January 23, 2023 10:54
@alice4space alice4space merged commit 64d71fe into alice4space:main Jan 23, 2023
@12rambau 12rambau deleted the viz branch January 23, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve plotting
2 participants