KeyframeSelection: Add support for masks #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/keyframeMaskSupport
branch
2 times, most recently
from
82cc4ad to
ee4b447
Compare
A list of paths to directories containing masks to apply during the computation of the scores can now be provided as an input. If a camera rig is being used and masks are provided, then the number of directories containing masks must be the same as the number of media paths.
cbentejac
force-pushed
the
dev/keyframeMaskSupport
branch
2 times, most recently
from
f680245 to
c3a53da
Compare
If masks are provided and correspond to the input frames (same number of frames and masks), load them along the frames. They are so far not used in the score computations.
If masks have been provided and have passed all the checks (size of the masks, number of masks, non-emptiness), apply them to the input frames before the sharpness score is computed. If a mask covers at least 50% of an evaluated window, it is ignored and we go on to sliding the window.
The optical flow is computed, and the mask is then applied on the integral of the motion vectors. The summed motion values will then be equal to 0 wherever the mask is applied. When computing the norm of the cell, if we detect that at least 50% of the cell is masked (by counting the number of 0s within the cell)
cbentejac
force-pushed
the
dev/keyframeMaskSupport
branch
from
c3a53da to
583ed52
Compare
mugulmd
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the support of masks to the smart keyframe selection method. When a mask folder is provided, and if these masks correspond to the input sequence(s) (identical number and size of frames), the masks are loaded alongside the frames and are applied during the score computation.
For the sharpness score, the mask is applied on the integral and squared integral images. If the mask covers 50% of the window that is currently evaluated, said window is skipped. This is to avoid having artificially high sharpness scores that are based on a very limited (and mainly masked) region of the image.
For the optical flow score, the mask is also applied on the 2-channel integral image, and similarly, if the mask covers 50% of the currently evaluated cell or more, it is skipped and not added to the vector of cells from which the final score is computed.
Multi-threading, which has been enabed in #1512, also works when masks are provided. If no mask folder is provided, the computation of scores runs as usual.
This relates to alicevision/Meshroom#2167.
Features list