-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New LDR2HDR software #613
Merged
Merged
New LDR2HDR software #613
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
616a990
[hdr] New HDR module with Robertson calibration
ToukL f5b58d7
[software] New software for fusion of LDR images into HDR
ToukL 66ab190
[hdr] add some arguments for HDR software
ToukL ca10227
[WIP] add Debevec algorithm
ToukL 1bc7cc2
[hdr] add Grossberg algorithm
ToukL 9996e35
[hdr] Add some parameters
ToukL ff885e8
[hdr] Fix Grossberg algorithm
ToukL 850ed41
[hdr] Adapt weight curves to method
ToukL eeaf1c4
[hdr] Visual Studio build fixes
fabiencastan b9b0c7c
[cmake] new option ALICEVISION_BUILD_HDR
fabiencastan f808396
[image] clean log + remove unused code
ToukL 44402a3
[hdr] rename arguments and add options
ToukL 40a9ba2
[raw] bug fix: can now read several images in folder
ToukL 45e1865
[hdr] add log infos and raw extensions
ToukL dacdbc6
[hdr] bug fix: can take input camera response instead of calibration
ToukL eb19a70
[hdr] add doxygen doc and correct some parameters
ToukL b1c7a2c
[hdr] add argument to recover the target source image
ToukL c2742eb
[hdr] correct some infos
ToukL 9ce0481
[hdr] delete old file
ToukL 7f4db7d
[hdr] correct codacy issues
ToukL cc41fa0
[hdr] correct codacy issue
ToukL 050de85
[hdr] change cout to log info
ToukL f006315
[hdr] separate calibration method argument and input response file
ToukL a37b54c
[hdr] add log info and remove goto
ToukL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,21 +86,21 @@ void RobertsonCalibrate::process(const std::vector< std::vector< image::Image<im | |
|
||
for(std::size_t iter = 0; iter < _maxIteration; ++iter) | ||
{ | ||
std::cout << "--> iteration : "<< iter << std::endl; | ||
// std::cout << "--> iteration : "<< iter << std::endl; | ||
|
||
std::cout << "1) compute radiance "<< std::endl; | ||
// std::cout << "1) compute radiance "<< std::endl; | ||
//initialize radiance | ||
for(std::size_t g = 0; g < ldrImageGroups.size(); ++g) | ||
{ | ||
merge.process(ldrImageGroups[g], times[g], weight, response, _radiance[g], targetTime, threshold, true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if it makes sense to expose the |
||
} | ||
|
||
std::cout << "2) initialization new response "<< std::endl; | ||
// std::cout << "2) initialization new response "<< std::endl; | ||
//initialize new response | ||
rgbCurve newResponse = rgbCurve(channelQuantization); | ||
newResponse.setZero(); | ||
|
||
std::cout << "3) compute new response "<< std::endl; | ||
// std::cout << "3) compute new response "<< std::endl; | ||
//compute new response | ||
for(unsigned int g = 0; g < ldrImageGroups.size(); ++g) | ||
{ | ||
|
@@ -133,11 +133,11 @@ void RobertsonCalibrate::process(const std::vector< std::vector< image::Image<im | |
//dividing the response by the cardinal curve | ||
newResponse *= card; | ||
|
||
std::cout << "4) normalize response"<< std::endl; | ||
// std::cout << "4) normalize response"<< std::endl; | ||
//normalization | ||
newResponse.normalize(); | ||
|
||
std::cout << "5) compute difference"<< std::endl; | ||
// std::cout << "5) compute difference"<< std::endl; | ||
//calculate difference between the old response and the new one | ||
rgbCurve responseDiff = newResponse - response; | ||
responseDiff.setAllAbsolute(); | ||
|
@@ -147,14 +147,14 @@ void RobertsonCalibrate::process(const std::vector< std::vector< image::Image<im | |
//update the response | ||
response = newResponse; | ||
|
||
std::cout << "6) check end condition"<< std::endl; | ||
// std::cout << "6) check end condition"<< std::endl; | ||
//check end condition | ||
if(diff < _threshold) | ||
{ | ||
std::cout << "[BREAK] difference < threshold " << std::endl; | ||
break; | ||
} | ||
std::cout << "-> difference is " << diff << std::endl; | ||
// std::cout << "-> difference is " << diff << std::endl; | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
ALICEVISION_LOG_TRACE("DebevecCalibrate: system solved");
And same for all other cout.