-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] KeyframeSelection
node could fail more gracefully
#2153
Comments
Hi @Shrinks99, I'm currently working on a few improvements for the Keyframe Selection: I'll add that one in! |
Hi @Shrinks99, Would it please be possible for you to share your video? I do not seem to have a single video with consecutive missing frames and would like to make sure that alicevision/AliceVision#1510 behaves correctly in that use case. |
Sure, can I send it to you privately? |
Of course, you can send it to candice.bentejac@technicolor.com if that's alright with you. |
Hi @Shrinks99, alicevision/AliceVision#1510 has been merged, so this issue should not occur again. It's already available on the Thank you for your help! |
Is your feature request related to a problem? Please describe.
When a MOV or presumably other video file is loaded into Meshroom that the KeyframeSelection node is unable to read fully, the program attempts to read the next frame and if it is unable to do so the node fails outright.
Describe the solution you'd like
If the node could continue attempting or perhaps finish and continue with the processed frames instead, that would be helpful! I had a 14839 frame MOV fail on frame 14826. Throwing away hours of work because of two frames of bad data is kind of a bummer! 🙃
Describe alternatives you've considered
Allow users to specify a frame range in the KeyframeSelection node.
Additional context
The text was updated successfully, but these errors were encountered: