Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] KeyframeSelection node could fail more gracefully #2153

Closed
Shrinks99 opened this issue Aug 14, 2023 · 5 comments · Fixed by alicevision/AliceVision#1510
Closed
Assignees
Labels
feature request feature request from the community

Comments

@Shrinks99
Copy link

Is your feature request related to a problem? Please describe.
When a MOV or presumably other video file is loaded into Meshroom that the KeyframeSelection node is unable to read fully, the program attempts to read the next frame and if it is unable to do so the node fails outright.

Describe the solution you'd like
If the node could continue attempting or perhaps finish and continue with the processed frames instead, that would be helpful! I had a 14839 frame MOV fail on frame 14826. Throwing away hours of work because of two frames of bad data is kind of a bummer! 🙃

Describe alternatives you've considered
Allow users to specify a frame range in the KeyframeSelection node.

Additional context

[2023-08-13 22:25:33.435242] [0x00006bf8] [trace]   Embedded OCIO configuration file: 'C:\Program Files\Meshroom-2023.2.0\aliceVision/share/aliceVision/config.ocio' found.
Program called with the following parameters:
 * brands =  = [Apple]
 * csvFilename = "scores.csv" (default)
 * exportFlowVisualisation = 0
 * exportScores = 0
 * exportSelectedFrames = 0 (default)
 * flowCellSize = 90
 * flowVisualisationOnly = 0
 * inputPaths =  = [E:/Kitchen Scan/source/08132023_175549084.mov]
 * maxCoresAvailable =  Unknown Type "unsigned int" (default)
 * maxFrameStep =  Unknown Type "unsigned int" (default)
 * maxMemoryAvailable = 18446744073709551615 (default)
 * maxNbOutFrames =  Unknown Type "unsigned int"
 * minFrameStep =  Unknown Type "unsigned int" (default)
 * minNbOutFrames =  Unknown Type "unsigned int"
 * mmFocals =  Unknown Type "class std::vector<float,class std::allocator<float> >"
 * models =  = [iPhone XR]
 * outputExtension = "exr"
 * outputFolder = "E:/Kitchen Scan/MeshroomCache/KeyframeSelection/cb2ed6fb0fbd7ff8301e9740da5d61057f5ded47"
 * outputSfMDataFrames = "E:/Kitchen Scan/MeshroomCache/KeyframeSelection/cb2ed6fb0fbd7ff8301e9740da5d61057f5ded47/frames.sfm"
 * outputSfMDataKeyframes = "E:/Kitchen Scan/MeshroomCache/KeyframeSelection/cb2ed6fb0fbd7ff8301e9740da5d61057f5ded47/keyframes.sfm"
 * pxDisplacement = 10
 * renameKeyframes = 0
 * rescaledWidthFlow = 720
 * rescaledWidthSharpness = 720
 * sensorDbPath = "C:\Program Files\Meshroom-2023.2.0\aliceVision\share\aliceVision\cameraSensors.db"
 * sharpnessWindowSize = 200
 * skipSelection = 0
 * skipSharpnessComputation = 0
 * storageDataType =  Unknown Type "enum aliceVision::image::EStorageDataType"
 * useSmartSelection = 1
 * verboseLevel = "info"

Hardware : 
	Detected core count : 32
	OpenMP will use 32 cores
	Detected available memory : 51824 Mo

[22:25:33.439242][info] Single camera
[22:25:33.439242][info] Camera: E:/Kitchen Scan/source/08132023_175549084.mov
	 - brand: Apple
	 - model: iPhone XR
	 - focal (mm): 5.6
[22:25:34.065531][info] Finished processing frame 1/14839
[22:25:34.614899][info] Finished processing frame 2/14839
[22:25:35.156666][info] Finished processing frame 3/14839
[22:25:35.699480][info] Finished processing frame 4/14839
...
[00:24:40.727519][info] Finished processing frame 14823/14839
[00:24:41.202208][info] Finished processing frame 14824/14839
[00:24:41.676940][info] Finished processing frame 14825/14839
[00:24:41.693623][warning] Invalid or missing frame 14826, attempting to read frame 14827.
[00:24:41.949216][fatal] Could not go to frame 14827 either. The feed might be corrupted.
@Shrinks99 Shrinks99 added the feature request feature request from the community label Aug 14, 2023
@cbentejac cbentejac self-assigned this Aug 14, 2023
@cbentejac
Copy link
Contributor

Hi @Shrinks99,

I'm currently working on a few improvements for the Keyframe Selection: I'll add that one in!

@cbentejac
Copy link
Contributor

Hi @Shrinks99,

Would it please be possible for you to share your video?

I do not seem to have a single video with consecutive missing frames and would like to make sure that alicevision/AliceVision#1510 behaves correctly in that use case.

@Shrinks99
Copy link
Author

Shrinks99 commented Aug 18, 2023

Sure, can I send it to you privately?

@cbentejac
Copy link
Contributor

Of course, you can send it to candice.bentejac@technicolor.com if that's alright with you.

@cbentejac
Copy link
Contributor

Hi @Shrinks99,

alicevision/AliceVision#1510 has been merged, so this issue should not occur again. It's already available on the develop branch of AliceVision (if you're building it yourself), and will be part of the next release.

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request from the community
Projects
None yet
2 participants