[keyframe] Do not fail when there are consecutive missing frames for the smart Keyframe Selection method #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some specific cases (e.g. when minFrameStep = 0 and maxFrameStep = 1), the computed step could be equal to 0, meaning that the following `for` loop would never progress, getting the whole program stuck.
cbentejac
force-pushed
the
fix/keyframeSelectionFailures
branch
from
2f241e4 to
5f6289d
Compare
2 tasks
…sing When a frame was missing in a VideoFeed, the behaviour used to be to skip it and try to read the next one. If the next one was missing as well, the whole process would stop and fail, with the assumption that the feed was corrupted. Instead of that, we now keep on skipping the frame and attempting to read the next one until a valid frame is found or there is no frame left to read. Dummy scores are still pushed for every frame that is missing.
…iles Instead of stopping (and cancelling) the writing of the output SfMData file whenever a frame cannot be read, we should check whether the feed is a VideoFeed or not: if it is, then it is possible to encounter missing or corrupted frames and these cases should be handled by skipping said missing or corrupted frames; if it is not, then the frames should already be on disk and there shouldn't be any error when reading them, hence the `return false` statement.
cbentejac
force-pushed
the
fix/keyframeSelectionFailures
branch
from
e1f56e9 to
081f68e
Compare
mugulmd
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the behaviour when encoutering missing frames during the score computation for the smart keyframe selection method. Prior to it, when a frame was missing, we skipped it and attempted to read to the next one:
Instead of stopping and failing when consecutive missing frames are encountered, the score computation keeps on going until it is able to read a frame or it has reached the end of the video. Dummy scores are pushed for every missing frame.
This should resolve alicevision/Meshroom#2153.
Additionally, this PR fixes a bug that could occur with the regular keyframe selection method when
minFrameStepandmaxFrameStephad specific values that led to a "step" value of 0, thus causing an infinite loop.Features list