Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] PanoramaWarping: remove obsolete image output attributes #1914

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Mar 2, 2023

Description

Since this PR was merged, the output images of the PanoramaWarping node are stored on disk as several tiles, and there is currently no system to support tiles in the 2D viewer.
Therefore, double-clicking on the PanoramaWarping node results in an empty 2D viewer.

This PR simply removes the image attributes from the node description, thus double-clicking the node won't have any effect.

@mugulmd mugulmd requested a review from fabiencastan March 2, 2023 12:59
@mugulmd mugulmd self-assigned this Mar 2, 2023
@fabiencastan fabiencastan added this to the Meshroom 2023.1.0 milestone Mar 3, 2023
@fabiencastan fabiencastan merged commit 6db0602 into develop Mar 3, 2023
@fabiencastan fabiencastan deleted the mug/rmPanoWarpOutImgs branch March 3, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants