Error when reinstalling all

[AlexanderProd]

When trying to reinstall all from the main menu I'm getting the following error seems like there's a problem with paths and directories.

I've been using version 2.3

Traceback (most recent call last):
  File "/usr/local/bin/shallow-backup", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/__main__.py", line 159, in cli
    reinstall_all_sb(dotfiles_path, packages_path, fonts_path, configs_path)
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/reinstall.py", line 129, in reinstall_all_sb
    reinstall_dots_sb(dotfiles_path)
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/reinstall.py", line 26, in reinstall_dots_sb
    copyfile(file, home_path)
  File "/usr/local/Cellar/python/3.7.1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py", line 121, in copyfile
    with open(dst, 'wb') as fdst:
IsADirectoryError: [Errno 21] Is a directory: '/Users/alexanderhoerl'

[alichtman]

Hmm. I'll look into this as soon as I have time. Looks like an error introduced in the last version, maybe?

[AlexanderProd]

Just tried it in version 2.2 installed from pip and the bug happens there as well with the same error message. I've also created a new backup and deleted the config file.

[alichtman]

Related to #209?

[AlexanderProd]

I guess not because I don’t have any sublime text backups.

[alichtman]

Well, it's not necessarily specific to the backup. The root of the issue is that a copying function call fails.

[AlexanderProd]

Oh yeah you're right I guess they have a similar root. Does reinstalling all work for you?

[alichtman]

Yep, I get the same error. It's a bit weird because the error is thrown on a line that should be impossible to hit with this code. Err: Is a directory but thrown on a line that can only be hit if the path is not a directory.

[robbixc]

Hey :) any news on this? I also hit the bug. I'm on ubuntu 18.04

[alichtman]

@robbixc Unfortunately, I haven't had any time to work on this. I likely won't have any time for the foreseeable future, either. I'd like to bring on another maintainer for this project... But that's a conversation for a different thread.

Short answer is: no progress.

[heysupratim]

Hey just informing that this issue still exists on 3.2

[alichtman]

Happy to review a PR for this if you put one together. I don't have time to resolve this bug at the moment, and it doesn't interfere with my workflow, so it's not high priority for me. I agree it's an important bug to resolve, it just hasn't hit the top of my list in a long time. @heysupratim

[heysupratim]

Hope this helps 🤗