Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't backup global npm packages? #61

Closed
NightMachinery opened this issue Sep 1, 2018 · 6 comments
Closed

It doesn't backup global npm packages? #61

NightMachinery opened this issue Sep 1, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@NightMachinery
Copy link

The program needs to run npm ls --parseable=true -g instead of just npm ls --parseable=true to list global packages.

@alichtman
Copy link
Owner

That sounds right to me. Want to open a PR? @NightMachinary

@alichtman alichtman added the bug Something isn't working label Sep 1, 2018
@NightMachinery
Copy link
Author

NightMachinery commented Sep 4, 2018 via email

@alichtman
Copy link
Owner

Honestly, I'm not really a node developer and don't work with npm that much.

It looks like it backs up local node modules (so, goes up through the file tree until it finds a node_modules directory and backs up whatever is in that.)

That's an oversight on my part, and should be fixed.

@shobrook
Copy link

shobrook commented Sep 5, 2018

@NightMachinary Y'know.. it's open source for a reason

https://youtu.be/TviGil-U2HE?t=36s

@preetham
Copy link

preetham commented Oct 9, 2018

Can I work on this ?

@alichtman
Copy link
Owner

Go for it, @kamidipreetham.

I think the correct fix was suggested by @NightMachinary, so try that out and see if it solves the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants