Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract lists of files/directories that don't change to a constants file #67

Closed
alichtman opened this issue Oct 9, 2018 · 4 comments
Closed

Extract lists of files/directories that don't change to a constants file #67

alichtman opened this issue Oct 9, 2018 · 4 comments
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alichtman
Copy link
Owner

No description provided.

@alichtman alichtman added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 9, 2018
@alichtman alichtman mentioned this issue Oct 9, 2018
Merged
@raypatterson77
Copy link

I'm interested in working on this one, but I'm not sure if I get this right.
Due to the reference on issue #63 should the list contain the files and directories that are changed when reinstalling the backup?

@alichtman
Copy link
Owner Author

alichtman commented Oct 11, 2018 •
edited
Loading

Correct, but this extends further than that. All hardcoded lists and dictionaries should be extracted to a constants file instead of being declared in the python script. You should coordinate with @schilli91 to make sure you're not doing duplicate work.

@raypatterson77
Copy link

ok

@alichtman alichtman mentioned this issue Oct 15, 2018
Closed
@alichtman
Copy link
Owner Author

Actually, we're not going to do this. Files to be backed up should go in a config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alichtman @raypatterson77