-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create .gitignore to protect private files #71
Comments
100% agreed. Let's make this as safe as possible. The defaults should be designed with two things in mind:
Now that I think about it, there might be some security concerns with making the list of software you have downloaded public. Let's say there's a vulnerability disclosed publicly in For that reason, I think the only "public by default" items we should have are dotfiles ( Implementation Plan Every time a user goes to back up, we should ask if it's a private backup or a public backup. If public, we should create a dotfile protecting important files from being uploaded to github. I'm thinking the text for this dotfile should go in a constants file (#67). |
.gitignore
with important files to not upload..gitignore
to protect private files
.gitignore
to protect private files
That's very true. What would probably work best is to rework it where the generated folder has the backed up data divided into |
Ok, that's a cool idea, actually.
I do want this to be fully integrated into the tool. No shell commands or outside interaction should be necessary. The way I'm imagining this at the moment is:
Broke this issue out into #79. The feature isn't fully implemented yet, but the only part I'm missing is the "public/private" separation. I added automatic |
If you were to backup your shallow-backup to github, it would be important for
dotfiles/.ssh
to be added automatically to.gitignore
, and, in my opinion,packages/installed_apps_list.txt
would be as well, because that's more related to private device use than development use.I would say that backing up to Github should be a public action, and therefore the data from the shallow-backup that is sent should all be very public information.
Of course, users can edit the
.gitignore
file all they want, but it should be communicated to them that they are potentially uploading sensitive information to the public internet.For example, here's my shallow-backup on github:
https://github.com/jasikpark/caleb-jasik-shallow-backup
The text was updated successfully, but these errors were encountered: