Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect XDG Base Directory spec #239

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Respect XDG Base Directory spec #239

merged 1 commit into from
Nov 14, 2019

Conversation

alichtman
Copy link
Owner

Fix #236

@alichtman alichtman merged commit 3189723 into master Nov 14, 2019
@alichtman
Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- shallow_backup/upgrade.py  7

See the complete overview on Codacy

@alichtman alichtman deleted the conform-to-xdg-spec branch November 14, 2019 13:20
alichtman
alichtman commented Nov 14, 2019
View reviewed changes
shallow_backup/upgrade.py
if os.path.isfile(old_config_path):
if prompt_yes_no("Config file from a version before v3.0 detected. Would you like to upgrade?", Fore.GREEN):
new_config_path = get_config_path()
print_green_bold(f"Moving {old_config_path} to {new_config_path}")
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: invalid syntax

alichtman added a commit that referenced this pull request Nov 15, 2019
@alichtman
Respect XDG Base Directory spec (#239)
42f4b59 
Fix #236
alichtman added a commit that referenced this pull request Nov 15, 2019
@alichtman
Fix tests (#238)
d0d7867 
* Begin reworking tests

Progress on #237

* Respect XDG Base Directory spec (#239)

Fix #236

* Fix config creation bug

* Get all tests to pass

Fix #237

* Apparently travis VMs don't come with /tmp created already

* Wrong diagnosis of the issue
alichtman added a commit that referenced this pull request Mar 22, 2020
@alichtman
Fix tests (#238)
2d07e5f 
* Begin reworking tests

Progress on #237

* Respect XDG Base Directory spec (#239)

Fix #236

* Fix config creation bug

* Get all tests to pass

Fix #237

* Apparently travis VMs don't come with /tmp created already

* Wrong diagnosis of the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform to XDG spec
1 participant
@alichtman