Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shallow-backup just crashes if repo can't be created #312

Closed
wants to merge 11 commits into from

Conversation

alichtman
Copy link
Owner

Fixes #308

@alichtman alichtman changed the title shallow-backup crashes if repo can't be created fix: shallow-backup just crashes if repo can't be created Jun 19, 2022
@alichtman
Copy link
Owner Author

alichtman commented Jun 19, 2022

looks fine to me but needs to be tested
Edit: indentation doesn't look right

alichtman and others added 10 commits August 29, 2023 00:10
I think this bug was the longest standing bug in any of my projects, ever. I opened this bug report (#229) over 4 years ago!

It's really not that complicated of a fix, either. I'm disappointed that this took me so long to fix.

 `shallow-backup` will only support a nested `dotfiles` repo. If it exists, prompt the user to make a commit in the submodule first to avoid a failed commit on the parent repo later.

Fix #229
@alichtman alichtman closed this Oct 9, 2023
@alichtman
Copy link
Owner Author

Done in aade620

@alichtman alichtman deleted the alichtman/issue308 branch November 16, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shallow-backup crashes if repo can't be created
2 participants