Support language tags with more than one hyphen #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language tags are composed of one or more subtags (reference: https://en.wikipedia.org/wiki/IETF_language_tag) and are not limited to two subtags with one hyphen. Fixed the "jsNormalizedLang" utility function to support more than one hyphen (for example, "zh-Hant-HK").
|
Hi @alienfast / @rosskevin, I just want to check if you received this and if you have any comments or concerns with this pull request. Thanks! |
|
Hey @martian111, sorry, I didn't see it. It looks like ci didn't run on this, I'll check it out. |
rosskevin
approved these changes
Feb 9, 2024
rosskevin
approved these changes
Feb 9, 2024
|
Hang in there with the notifications @martian111 - I'm using this to get my github actions workflow triggers corrected. |
No problem at all, thank you! |
|
🚀 PR was released in |
|
Thanks @martian111, I finally sorted out a working workflow for external committers, sorry it took so long. Thank you for pinging me because I wasn't watching the repo (and I am now). |
|
Thank you too @rosskevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language tags are composed of one or more subtags (reference: https://en.wikipedia.org/wiki/IETF_language_tag) and are not limited to two subtags with one hyphen. Fixed the "jsNormalizedLang" utility function to support more than one hyphen (for example, "zh-Hant-HK").
Before this fix, such language tags would cause invalid code to be generated, such as:
export const zh_Hant-HK = {"translation":{"layouts":{"header":{"title":"Example Title"}}}