fix: invalid_client response is missing application/json content-type #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 17 17
Lines 734 734
Branches 114 114
=======================================
Hits 693 693
Misses 32 32
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aioauth/errors.py
Outdated
| super().__init__(request, description, headers or HTTPHeaderDict()) | ||
| super().__init__(request, description, headers or default_headers) |
There was a problem hiding this comment.
Passing the default headers by reference here will have the self.headers['WWW-Authenticate"] = ... assignment in L101 below also modify default_headers. HTTPHeaderDict(default_headers) works though.
There was a problem hiding this comment.
oh you are right, stupid mistake on my part 🤦🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue #85