Skip to content

Commit

Permalink
[promoted]Merge pull request ansible-collections#586 from tremble/cle…
Browse files Browse the repository at this point in the history
…anup/elb

Cleanup ec2_elb*

SUMMARY
This effectively reverts ansible/ansible#30532
@wimnat originally tried to keep ec2_elb, ec2_elb_lb and their fact/info partners separate from elb_instance / elb_classic_lb so that when a boto3 migration was performed the API/return values could be changed.  We no longer have a 'preview' flag on the interface, so this is just causing duplication.

ec2_elb_info now has a boto3 based equivalent elb_classic_lb_info deprecate it so we can drop the old boto based module
elb_classic_lb was never rewritten, point it at amazon.aws.ec2_elb_lb so we only try and do the boto3 migration in one place
elb_instance was never rewritten, point ec2_elb at community.aws.elb_instance so we only try and do the boto3 migration in one place

Before we release 2.0.0 let's get this back to something vaguely consistent.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_elb
ec2_elb_lb
ec2_elb_info
elb_classic_lb
elb_classic_lb_info
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b946932
  • Loading branch information
ansible-zuul[bot] committed Jul 9, 2021
2 parents 80292ae + 4843bb5 commit 75d97cd
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 75d97cd

Please sign in to comment.