Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Task #1

wants to merge 7 commits into from

Conversation

alinamusuroi
Copy link
Owner

@alinamusuroi alinamusuroi commented Nov 11, 2018 •
edited
Loading

test7

nikitadhiman
nikitadhiman reviewed Nov 11, 2018
View reviewed changes
Copy link

@nikitadhiman nikitadhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes did you make for test environment? I'm unable to see any changes

@nikitadhiman
Copy link

Can you add some sample test case, it can be as simple as console.log

@alinamusuroi
Copy link
Owner Author

alinamusuroi commented Nov 11, 2018 •
edited
Loading

@nikitadhiman Is it ok now? It is my first time running tests ...

nikitadhiman
nikitadhiman reviewed Nov 11, 2018
View reviewed changes
Copy link

@nikitadhiman nikitadhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this PR doesn't contain any changes or tests

@alinamusuroi
Copy link
Owner Author

alinamusuroi commented Nov 11, 2018 •
edited
Loading

@nikitadhiman So sorry. I forgot to actually upload the file. I just added it in the preview. I think it should appear now.

@nikitadhiman
Copy link

Sorry but I still can't see any changes in files..... Just some jpg files

@nikitadhiman
Copy link

Code for test cases is needed as a submission

@alinamusuroi
Copy link
Owner Author

@nikitadhiman So I have to create a new file just with the code for the test?

@nikitadhiman
Copy link

nikitadhiman commented Nov 11, 2018 via email

@alinamusuroi
Copy link
Owner Author

alinamusuroi commented Nov 11, 2018 •
edited
Loading

@nikitadhiman Is it okay now?

@nikitadhiman
Copy link

Great!! Submit your task for approval. You should follow this Everytime you submit a task. Good work

@alinamusuroi
Copy link
Owner Author

@nikitadhiman Thank you for your patience.:))

@nikitadhiman
Copy link

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadhiman nikitadhiman nikitadhiman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alinamusuroi @nikitadhiman