Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up redundunt code #278

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Clean up redundunt code #278

merged 1 commit into from
Oct 11, 2018

Conversation

chansuke
Copy link
Collaborator

@chansuke chansuke commented Oct 7, 2018

No description provided.

fungilation
fungilation suggested changes Oct 7, 2018
View reviewed changes
webview-bridge/index.ios.js Outdated
var { PropTypes } = PropTypes;
NativeModules: { WebViewBridgeManager }
} = ReactNative
var { PropTypes } = PropTypes
Copy link
Contributor

@fungilation fungilation Oct 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var { PropTypes } = PropTypes redundant, I see already gone in index.android.js

@chansuke chansuke force-pushed the hotfix/delete-redundunt-code branch from 3a960c7 to 606903b Compare October 8, 2018 03:25
@chansuke
Copy link
Collaborator Author

chansuke commented Oct 8, 2018

@fungilation Oh, sorry I've rebased, but updated.

@fungilation
Copy link
Contributor

Cool. When you can, the other 3 small changes I requested in #273 (review) so I can stop maintaining my fork and go back to yours please ;)

@chansuke chansuke force-pushed the hotfix/delete-redundunt-code branch 2 times, most recently from d33ff6f to c4eeaf2 Compare October 9, 2018 15:10
@fungilation
Copy link
Contributor

These commits confuses me. var { PropTypes } = PropTypes was gone in index.android.js, but now it's back?

@chansuke
Copy link
Collaborator Author

Sorry, I deleted it too.

@fungilation
Copy link
Contributor

Cool. Merge please

@chansuke chansuke merged commit 45e0254 into master Oct 11, 2018
@chansuke chansuke deleted the hotfix/delete-redundunt-code branch October 11, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fungilation fungilation fungilation requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chansuke @fungilation