Rename latestVersion to isStale and use boolean

Co-Authored-By: Austin Ziegler <austin@zieglers.ca>
alisinabh · Jan 8, 2025 · 8ef47f0 · 8ef47f0
1 parent 66129df
commit 8ef47f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/assets/js/handlebars/templates/versions-dropdown.handlebars b/assets/js/handlebars/templates/versions-dropdown.handlebars
@@ -2,10 +2,10 @@
   <label>
     <span class="sidebar-projectVersionsDropdownCaret" aria-hidden="true">&#x25bc;</span>
     <span class="sr-only">Project version</span>
-    {{#if latestVersion}}
+    {{#if isStale}}
       <i class="ri-alert-line sidebar-staleIcon" aria-hidden="true"></i>
     {{/if}}
-    <select class="sidebar-projectVersionsDropdown{{#if latestVersion}} sidebar-staleVersion{{/if}}"{{#if latestVersion}} title="This version is not the latest version of the package."{{/if}}>
+    <select class="sidebar-projectVersionsDropdown{{#if isStale}} sidebar-staleVersion{{/if}}"{{#if isStale}} title="This version is not the latest version of the package."{{/if}}>
       {{#each nodes}}
         <option translate="no" value="{{url}}"{{#if isCurrentVersion}} selected disabled{{/if}}>
           {{version}}

diff --git a/assets/js/sidebar/sidebar-version-select.js b/assets/js/sidebar/sidebar-version-select.js
@@ -17,17 +17,17 @@ export function initialize () {
     const currentVersion = versionsContainer.textContent.trim()
 
     const latestVersionNode = versionNodes.find(node => node.latest)
-    const latestVersion = latestVersionNode?.version !== currentVersion ? latestVersionNode?.version : null
+    const isStale = latestVersionNode?.version !== currentVersion
 
     const nodes = decorateVersionNodes(versionNodes, currentVersion)
 
-    renderVersionsDropdown({ nodes, latestVersion })
+    renderVersionsDropdown({ nodes, isStale })
   }
 }
 
-function renderVersionsDropdown ({ nodes, latestVersion }) {
+function renderVersionsDropdown ({ nodes, isStale }) {
   const versionsContainer = qs(VERSIONS_CONTAINER_SELECTOR)
-  const versionsDropdownHtml = versionsDropdownTemplate({ nodes, latestVersion })
+  const versionsDropdownHtml = versionsDropdownTemplate({ nodes, isStale })
   versionsContainer.innerHTML = versionsDropdownHtml
 
   qs(VERSIONS_DROPDOWN_SELECTOR).addEventListener('change', handleVersionSelected)