-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pasargad driver | resovles #13 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two optional parameters have been mentioned in pep sdks and documents inconsistently. Therefore it is best to avoid them for the time being untill we can test them with the real pep api
alitnk
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13
The Pasargad driver and it's Api are implemented via Pasargad documents , Pasargad SKDs , Pasargad Swagger and the unit tests are provided.
However, I can say with confidence, even though I've surfed through the pasargad documentation and every sdk of this bank, this driver is likely to fail while interacting with the real api and there are several reasons for it:
Anyway, I'm trying to contact their developer of the Nodejs SDK and get some pull requests merged to fix it.
This driver is built upon the most used SDK (php sdk) and the documentation but still I am not sure what Pasargad has in store for us. I guess we'll never know until someone tests it IRL.
The current problems:
rsa-xml
file by Pasargad, while the driver needs thepem
version. So the developers have to convert it in order to use the driver (Via libraries or online converters). I was unable to find a reliable way to convert them in drivercrypto
errors are inconvenient for a developer who does not know about the signing processI'll submit and track the problems in issues section.
Sorry for the long description