Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Context error if it is canceled before at least 1 task failed #40

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Return Context error if it is canceled before at least 1 task failed #40

merged 2 commits into from
Jan 31, 2023

Conversation

alitto
Copy link
Owner

@alitto alitto commented Jan 31, 2023 •
edited
Loading

@alitto alitto merged commit 2fbcfba into master Jan 31, 2023
micronull
micronull reviewed Feb 1, 2023
View reviewed changes
group_blackbox_test.go

err := group.Wait()
assertEqual(t, context.Canceled, err)
assertEqual(t, int32(0), atomic.LoadInt32(&doneCount))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startedCount is not checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micronull micronull micronull left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alitto @micronull