fix: update to env ALIBABA_CLOUD_IMDSV1_DISABLED for imds v1 disabled

aliyun · Sep 12, 2024 · 1d5d242 · 1d5d242
1 parent e541552
commit 1d5d242
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README-CN.md b/README-CN.md
@@ -229,7 +229,7 @@ func main(){
     SetType("ecs_ram_role").
     // `roleName` is optional. It will be retrieved automatically if not set. It is highly recommended to set it up to reduce requests
     SetRoleName("RoleName").
-    // `DisableIMDSv1` is optional and is recommended to be turned on. It can be replaced by setting environment variable: ALIBABA_CLOUD_IMDSV1_DISABLE
+    // `DisableIMDSv1` is optional and is recommended to be turned on. It can be replaced by setting environment variable: ALIBABA_CLOUD_IMDSV1_DISABLED
     SetDisableIMDSv1(true)
 
   provider, err := credentials.NewCredential(config)

diff --git a/README.md b/README.md
@@ -248,7 +248,7 @@ func main(){
     SetType("ecs_ram_role").
     // `roleName` is optional. It will be retrieved automatically if not set. It is highly recommended to set it up to reduce requests
     SetRoleName("RoleName").
-    // `DisableIMDSv1` is optional and is recommended to be turned on. It can be replaced by setting environment variable: ALIBABA_CLOUD_IMDSV1_DISABLE
+    // `DisableIMDSv1` is optional and is recommended to be turned on. It can be replaced by setting environment variable: ALIBABA_CLOUD_IMDSV1_DISABLED
     SetDisableIMDSv1(true)
 
   provider, err := credentials.NewCredential(config)

diff --git a/credentials/internal/providers/ecs_ram_role.go b/credentials/internal/providers/ecs_ram_role.go
@@ -49,7 +49,7 @@ func (builder *ECSRAMRoleCredentialsProviderBuilder) Build() (provider *ECSRAMRo
 	}
 
 	if !builder.provider.disableIMDSv1 {
-		builder.provider.disableIMDSv1 = os.Getenv("ALIBABA_CLOUD_IMDSV1_DISABLE") == "true"
+		builder.provider.disableIMDSv1 = os.Getenv("ALIBABA_CLOUD_IMDSV1_DISABLED") == "true"
 	}
 
 	provider = builder.provider

diff --git a/credentials/internal/providers/ecs_ram_role_test.go b/credentials/internal/providers/ecs_ram_role_test.go
@@ -388,14 +388,14 @@ func TestECSRAMRoleCredentialsProvider_getMetadataToken(t *testing.T) {
 	_, err = p.getMetadataToken()
 	assert.Nil(t, err)
 
-	os.Setenv("ALIBABA_CLOUD_IMDSV1_DISABLE", "true")
+	os.Setenv("ALIBABA_CLOUD_IMDSV1_DISABLED", "true")
 	p, err = NewECSRAMRoleCredentialsProviderBuilder().Build()
 	assert.Nil(t, err)
 
 	_, err = p.getMetadataToken()
 	assert.NotNil(t, err)
 
-	os.Setenv("ALIBABA_CLOUD_IMDSV1_DISABLE", "")
+	os.Setenv("ALIBABA_CLOUD_IMDSV1_DISABLED", "")
 	p, err = NewECSRAMRoleCredentialsProviderBuilder().Build()
 	assert.Nil(t, err)