Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reuse provider name in chainable providers #127

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Nov 11, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 98.12%. Comparing base (1170807) to head (f89d6fb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
credentials/providers/default.go 40.00% 4 Missing and 2 partials ⚠️
credentials/providers/cli_profile.go 40.00% 2 Missing and 1 partial ⚠️
credentials/providers/profile.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   98.55%   98.12%   -0.44%     
==========================================
  Files          31       31              
  Lines        2701     2717      +16     
==========================================
+ Hits         2662     2666       +4     
- Misses         24       32       +8     
- Partials       15       19       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yndu13 yndu13 merged commit 115dc39 into master Nov 11, 2024
12 checks passed
@yndu13 yndu13 deleted the provider-name branch November 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants