Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw exception instead of fall back to default credentials chain #92

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

JacksonTian
Copy link
Contributor

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.37%. Comparing base (6ae5ad8) to head (f5789e5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/com/aliyun/credentials/Credential.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     91.39%   91.37%   -0.03%     
  Complexity      613      613              
============================================
  Files            45       45              
  Lines          2208     2202       -6     
  Branches        169      169              
============================================
- Hits           2018     2012       -6     
  Misses          128      128              
  Partials         62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian merged commit 1dabaf2 into master Sep 29, 2024
4 checks passed
@JacksonTian JacksonTian deleted the throw_instead_of_default_chain branch September 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants