Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/alicloud_ess_scaling_rules: add attributes of predictive_scaling_mode, initial_max_size, predictive_value_behavior, predictive_value_buffer, predictive_task_buffer_time, target_value and metric_name. #8133

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

fuliu-zln
Copy link
Contributor

data-source/alicloud_ess_scaling_rules: add attributes of predictive_scaling_mode, initial_max_size, predictive_value_behavior, predictive_value_buffer, predictive_task_buffer_time, target_value and metric_name.

if err != nil {
return WrapErrorf(err, FailedGetAttributeMsg, "$.ScalingRules.ScalingRule", response)
}
//if len(v.([]interface{})) < 1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@fuliu-zln fuliu-zln Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑翻页的时候,查到伸缩规则可能没有,此处注释被打开

@fuliu-zln fuliu-zln force-pushed the feat/ruleData branch 2 times, most recently from 581120c to f785338 Compare January 15, 2025 06:09
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

}
i, errConvert := w.(json.Number).Int64()
if errConvert != nil {
return WrapErrorf(err, FailedGetAttributeMsg, "转换失败", response)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

…scaling_mode, initial_max_size, predictive_value_behavior, predictive_value_buffer, predictive_task_buffer_time, target_value and metric_name
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@fuliu-zln
Copy link
Contributor Author

approved

image

@ChenHanZhang ChenHanZhang merged commit 0297402 into aliyun:master Jan 22, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants