Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Font Colour will Cause Errors #7

Closed
aljawaid opened this issue Dec 24, 2022 · 7 comments
Closed

BUG: Font Colour will Cause Errors #7

aljawaid opened this issue Dec 24, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@aljawaid
Copy link
Owner

Colours using font colours are check as if but should be isset

  • Add font colour to relevant colour as normal in the model
  • Check using isset before using it

Code Issues:

  • 0a74028 Add 3 Colours
  • 9cc4ce7 Add html entity for white text indication in dropdowns
  • 57913fe Add Font Color
@aljawaid aljawaid added the bug Something isn't working label Dec 24, 2022
@aljawaid aljawaid added this to the Add New Colours milestone Dec 24, 2022
@aljawaid aljawaid self-assigned this Dec 24, 2022
aljawaid referenced this issue Dec 24, 2022
aljawaid added a commit that referenced this issue Dec 24, 2022
@aljawaid
Copy link
Owner Author

@creecros I have changed the code, please check if any errors on your side before I go further with the plugin

aljawaid added a commit that referenced this issue Dec 24, 2022
@aljawaid
Copy link
Owner Author

@creecros I have changed the code, please check if any errors on your side before I go further with the plugin

my error log is fine, so unless you tell me something... the issets worked fine

@aljawaid
Copy link
Owner Author

@creecros closing as I can't find any errors now, please re-open if you find any issues

@creecros
Copy link
Collaborator

creecros commented Dec 27, 2022

no errors, but the font colors are ignored, which i would say defeats the purpose.

test3

@aljawaid
Copy link
Owner Author

no errors, but the font colors are ignored, which i would say defeats the purpose.

ah ok, that would be missing css, I will look into it. it work on tags and i been focussing on that.

@creecros
Copy link
Collaborator

creecros commented Dec 27, 2022

looking at the console, it's not missing but the font color is being trumped by other css.

image

@aljawaid
Copy link
Owner Author

looking at the console, it's not missing but the font color is being trumped by other css.

yes, i just had a quick look, certain classes to be overridden in the plugin are missing on my side... kanboard core is the classes you are seeing...

aljawaid added a commit that referenced this issue Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants