Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker path/get zip directory staging to work. #2

Closed

Conversation

lukecwik
Copy link

This allowed me to run the hacked up WordCount from Intellij by passing in the single argument:
--runner=org.apache.beam.runners.reference.PortableRunner


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@aljoscha aljoscha force-pushed the java-portable-job-submission branch from 280287e to f63e36f Compare March 27, 2018 06:48

// TODO: Migrate this logic else where.
try {
filesToStage = replaceDirectoriesWithZipFiles(filesToStage);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is always staging an empty list. I fixed this while incorporating into my branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aljoscha aljoscha force-pushed the java-portable-job-submission branch from f63e36f to 9e892cd Compare March 27, 2018 12:39
@lukecwik lukecwik closed this Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants