Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup table footer #341

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: cleanup table footer #341

merged 1 commit into from
Oct 6, 2022

Conversation

tenshiAMD
Copy link
Member

What:

Why:

  • Cleanup table footer to fix some linters

How:

  • Update implementation

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to the contributors' table

@tenshiAMD tenshiAMD self-assigned this Oct 6, 2022
@tenshiAMD tenshiAMD requested a review from a team as a code owner October 6, 2022 09:44
@tenshiAMD
Copy link
Member Author

tenshiAMD commented Oct 6, 2022 •
edited
Loading

TODO:

  • Add snapshot/s for testing footer

KnorpelSenf
KnorpelSenf approved these changes Oct 6, 2022
View reviewed changes
Copy link

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@tenshiAMD tenshiAMD merged commit 0be7a63 into master Oct 6, 2022
@tenshiAMD tenshiAMD deleted the tenshiamd/fix-table-footer branch October 6, 2022 14:20
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

Assignees

@tenshiAMD tenshiAMD

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove trailing whitespace (flagged by popular linters)
3 participants
@tenshiAMD @all-contributors-release-bot @KnorpelSenf