Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing await in puppeteer-custom-environment.ts #5301

Closed
brady-ds opened this issue Jul 24, 2021 · 1 comment · Fixed by #5302
Closed

Missing await in puppeteer-custom-environment.ts #5301

brady-ds opened this issue Jul 24, 2021 · 1 comment · Fixed by #5302

Comments

@brady-ds
Copy link

On this line of code:

super.handleTestEvent(event, state);

an async method is being called without the expected await, so the call does nothing (compare other calls to superclass methods in the same class).

See here for where the bug was originally caught; it has already been fixed in that comment thread.

@jmthibault79
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants