Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=no][no ticket] Await an async call #5302

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Jul 26, 2021

Description:

The example code (jestjs/jest#6527 (comment)) which we copied (#4660 (comment)) was incorrect, and has now been corrected in the original thread. Thanks for pointing this out @brady-ds !

Closes #5301


PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have run and tested this change locally
  • I have run the E2E tests on ths change against my local UI and/or API server with yarn test-local or yarn test-local-devup
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer
  • If this includes an API change, I have updated the appropriate Swagger definitions and notified API consumers
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later

@jmthibault79 jmthibault79 requested a review from aweng98 July 26, 2021 12:32
Copy link
Contributor

@aweng98 aweng98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for fixing it.

@jmthibault79 jmthibault79 merged commit 13b68ff into master Jul 26, 2021
@jmthibault79 jmthibault79 deleted the joel/await-handleTestEvent branch July 26, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing await in puppeteer-custom-environment.ts
2 participants