Domain style support #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 12, 2018 14:07
…domly picking one.
… during cluster setup.
mjarco
reviewed
Apr 3, 2018
storages/storages.go
Outdated
| // BackendAdapter holds the necessary backend info after decorating the backend | ||
| type BackendAdapter struct { | ||
| *Backend | ||
| } |
There was a problem hiding this comment.
I don' see the point for having this type, all it looks like no-op extension of Backend
added 5 commits
April 3, 2018 10:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for domain style support and rewriting domain style to path style.