-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex in release branch names #864
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
============================================
- Coverage 62.00% 61.96% -0.04%
Complexity 442 442
============================================
Files 83 83
Lines 1679 1680 +1
Branches 161 161
============================================
Hits 1041 1041
- Misses 569 570 +1
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -13,7 +13,7 @@ plugins { | |||
} | |||
|
|||
scmVersion { | |||
versionCreator("versionWithBranch") | |||
unshallowRepoOnCI.set(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can set it as default now, it's been working fine ;) !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First I would like to fix multiple "Unshallowing repo because build is being executed on CI" logs, I have that on my radar 😉
64b0521
to
ecbbb23
Compare
@@ -31,3 +31,12 @@ jobs: | |||
uses: codecov/codecov-action@v5 | |||
with: | |||
token: ${{ secrets.CODECOV_TOKEN }} | |||
|
|||
- name: Publish to staging repository | |||
run: ./gradlew publishToSonatype currentVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that snapshot was uploaded: https://oss.sonatype.org/service/local/repositories/snapshots/content/pl/allegro/tech/build/axion-release/pl.allegro.tech.build.axion-release.gradle.plugin/1.18.16-regex-in-release-branch-names-SNAPSHOT/pl.allegro.tech.build.axion-release.gradle.plugin-1.18.16-regex-in-release-branch-names-20241125.063939-2.pom
This PR allows to use regex patterns in
scmVersion.releaseBranchNames
and-Prelease.releaseBranchNames