Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex in release branch names #864

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Regex in release branch names #864

merged 1 commit into from
Nov 25, 2024

Conversation

radoslaw-panuszewski
Copy link
Collaborator

@radoslaw-panuszewski radoslaw-panuszewski commented Nov 23, 2024

This PR allows to use regex patterns in scmVersion.releaseBranchNames and -Prelease.releaseBranchNames

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.96%. Comparing base (cc1dac9) to head (ecbbb23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...egro/tech/build/axion/release/ReleasePlugin.groovy 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #864      +/-   ##
============================================
- Coverage     62.00%   61.96%   -0.04%     
  Complexity      442      442              
============================================
  Files            83       83              
  Lines          1679     1680       +1     
  Branches        161      161              
============================================
  Hits           1041     1041              
- Misses          569      570       +1     
  Partials         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@@ -13,7 +13,7 @@ plugins {
}

scmVersion {
versionCreator("versionWithBranch")
unshallowRepoOnCI.set(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can set it as default now, it's been working fine ;) !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First I would like to fix multiple "Unshallowing repo because build is being executed on CI" logs, I have that on my radar 😉

@radoslaw-panuszewski radoslaw-panuszewski force-pushed the regex-in-release-branch-names branch from 64b0521 to ecbbb23 Compare November 25, 2024 06:37
@radoslaw-panuszewski radoslaw-panuszewski marked this pull request as ready for review November 25, 2024 06:37
@@ -31,3 +31,12 @@ jobs:
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Publish to staging repository
run: ./gradlew publishToSonatype currentVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgalek bgalek merged commit 3d5aa62 into main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants