SKYEDEN-3234 detect unused topics #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
questras
commented
Nov 12, 2024
•
questras
commented
- Add a cron job to detect inactive topics and notify them
- notification thresholds, cron etc are configured via properties
- Notifier implementation is not provided, but the feature can work without it
- the job runs on one instance of hermes management only, based on provided ZK datacenter for leadership election (in properties)
moscicky
reviewed
Nov 28, 2024
| InactiveTopic limitNotificationsHistory(int limit) { | ||
| List<Long> newNotificationTimestampsMs = | ||
| notificationTimestampsMs.stream() | ||
| .sorted((a, b) -> Long.compare(b, a)) |
There was a problem hiding this comment.
nit: do we really need to sort this list? Timestamps should be order first so we can just take last limit elements?
There was a problem hiding this comment.
I don't want to rely on the current implementation that the timestamps will be sorted. If we ever change anything that changes the order of timestamps then we might get an unexpected behavior and this sorting makes sure we are always safe.
moscicky
previously approved these changes
Nov 28, 2024
* SKYEDEN-3271 |hermes management leader * SKYEDEN-3271 | cr changes
…-topics"" This reverts commit cf17940.
moscicky
previously approved these changes
Dec 17, 2024
szczygiel-m
previously approved these changes
Dec 18, 2024
| import io.micrometer.core.instrument.Tags; | ||
| import java.time.Clock; | ||
| import java.time.Instant; | ||
| import java.util.*; |
szczygiel-m
approved these changes
Dec 19, 2024
moscicky
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.