use experimental worker_threads to run tasks #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonka
commented
Jul 13, 2018
| workerStartTime.should.be.at.least(callTime); | ||
| workerNodes.workersQueue.forEach(worker => { | ||
| const startDate = worker.process.startDate; | ||
| if (startDate) { |
There was a problem hiding this comment.
I don't like this - suggestions welcomed
slonka
commented
Jul 13, 2018
lib/worker/process.js
Outdated
| // report readiness on a first message received from the child | ||
| // process (as it means that the child has loaded all the stuff | ||
| // into a memory and is ready to handle the calls) | ||
| if (message === 'ready') { |
There was a problem hiding this comment.
I don't like this - suggestions welcomed
slonka
force-pushed
the
native-workers
branch
2 times, most recently
from
dda8c0a
to
40d674a
Compare
slonka
commented
Jul 13, 2018
lib/worker/process.js
Outdated
| stdio: [0, 1, 2, 'pipe', 'ipc'] | ||
| this.startDate = null; | ||
|
|
||
| const child = new worker.Worker(require.resolve('./child-loader')); |
There was a problem hiding this comment.
rename child to thread?
slonka
force-pushed
the
native-workers
branch
5 times, most recently
from
5b55aa7
to
df9546f
Compare
|
Travis is now configured to use yarn, so we should update |
kwiatkk1
approved these changes
Jul 16, 2018
| }, | ||
| "scripts": { | ||
| "docs": "jsdoc2md -l off -t docs-src/Readme.hbs lib/*.js > Readme.md; echo", | ||
| "test": "mocha --trace-warnings -r tests/utils/setup.js {lib,tests}/**/*.spec.js", | ||
| "test": "node --experimental-worker node_modules/.bin/_mocha --trace-warnings -r tests/utils/setup.js {lib,tests}/**/*.spec.js", |
There was a problem hiding this comment.
We can get rid of msgpack-lite dependency, as it's not needed anymore.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next)