Fix renderer classes ordering

allegro · Nov 18, 2024 · d3bb229 · d3bb229
1 parent 530cac3
commit d3bb229
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/ralph/assets/tests/test_api.py b/src/ralph/assets/tests/test_api.py
@@ -958,8 +958,8 @@ def test_get_dc_hosts_list(self):
         VirtualServerFullFactory.create_batch(20, parent=dc_assets[0])
         CloudHostFullFactory.create_batch(20, hypervisor=dc_assets[0])
         url = reverse('dchost-list') + "?limit=100"
-        with self.assertNumQueries(31):
-            response = self.client.get(url, format='json')
+        with self.assertQueriesMoreOrLess(30, plus_minus=1):
+            response = self.client.get(url)
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         self.assertEqual(response.data['count'], 63)
 

diff --git a/src/ralph/lib/api/utils.py b/src/ralph/lib/api/utils.py
@@ -120,7 +120,10 @@ def render_form_for_serializer(self, serializer):
 
 
 def renderer_classes_without_form(renderer_classes):
-    return [OnlyRawBrowsableAPIRenderer] + [
-        rc for rc in renderer_classes
-        if not isinstance(rc(), BrowsableAPIRenderer)
-    ]
+    def _gen():
+        for rc in renderer_classes:
+            if not isinstance(rc(), BrowsableAPIRenderer):
+                yield rc
+            else:
+                yield OnlyRawBrowsableAPIRenderer
+    return [rc for rc in _gen()]