installing fixed version of protobufjs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evamaxfield
approved these changes
Jun 25, 2020
toloudis
approved these changes
Jun 25, 2020
toloudis
reviewed
Jun 25, 2020
| @@ -98,7 +98,7 @@ class MainPlotContainer extends React.Component<MainPlotContainerProps> { | |||
| this.renderPopover = this.renderPopover.bind(this); | |||
| } | |||
|
|
|||
| public componentWillMount() { | |||
| public componentDidMount() { | |||
There was a problem hiding this comment.
Once I got past the .gradlew test error, it errored out on ./gradlew lint. This used to be a warning, but now it's an error because they've deprecated componentWillMount. So it's technically a change to get the build to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request recommendations:
Thanks for contributing!
This error "Error: not supported" was being thrown by a dependency of a dependency, protobufjs. This error has been fixed in protobufjs, but not in a stable release yet.
The issue is
isNodecheck is failing.protobufjs/protobuf.js#1221
In order to make sure every package is using the new version, I used
npm shrinkwrapafter I edited the package-lock.jsonhttps://nodejs.org/en/blog/npm/managing-node-js-dependencies-with-shrinkwrap/