Make olmo-core checkpointer more robust on weka #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2015aroras
reviewed
Jun 14, 2024
olmo/checkpoint.py
Outdated
| local_files_created = save_model_and_optim_state( | ||
| checkpoint_dir, fsdp_model, optim, save_overwrite=self.cfg.save_overwrite | ||
| ) | ||
| local_files_created = save_model_and_optim_state(checkpoint_dir, fsdp_model, optim) |
There was a problem hiding this comment.
Why remove save_overwrite?
There was a problem hiding this comment.
We handle save_overwrite in this checkpointer class already. At this point in the code we're passing a temporary directory that we've guaranteed exists and is empty, so if we pass save_overwrite=True, then olmo-core will delete and recreate that directory, which can cause issues on weka/nfs.
2015aroras
approved these changes
Jun 14, 2024
IanMagnusson
pushed a commit
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.