Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Add Dockerfile.release #5

Merged
merged 32 commits into from
Nov 15, 2019
Merged

Conversation

brendan-ai2
Copy link
Contributor

@brendan-ai2
Copy link
Contributor Author

This enables the build I mentioned in my previous PR. Please take a look!

@@ -1,3 +1,8 @@
# Docker image for checking integration across the main repo (allennlp) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about how the directory structure is set up (not sure how you can copy allennlp and allennlp-semparse as you do), but I'll trust you've done whatever magic is necessary in the TC build machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for leaving that unclear! Added comment:

# We expect that the various repos are checked out under a directory matching
# their name, e.g. allennlp-semparse. A TeamCity build can be configured to do
# this by adding the checkout rule "+:.=>allennlp-semparse". These are found
# under "Version Control Settings" -> "VCS Roots" -> "Edit checkout rules".

I've also modified the other Dockerfile to adopt a more typical structure so that this isn't required for the common case. (Since we're only installing packages.)

@brendan-ai2
Copy link
Contributor Author

Thanks for the review!

@brendan-ai2 brendan-ai2 merged commit 9b091fe into allenai:master Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants