This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
move test and fixtures to root level and simplify test-install command #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
May 20, 2020
schmmd
reviewed
May 20, 2020
| import_module_and_submodules("allennlp.predictors") | ||
| import_module_and_submodules("allennlp.training") | ||
| logger.info("AllenNLP version %s installed to %s", VERSION, _get_module_root()) | ||
| logger.info("Cuda devices available: %s", torch.cuda.device_count()) |
schmmd
approved these changes
May 20, 2020
epwalsh
changed the title
|
@matt-gardner tests and fixtures are now at the root ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4252. We keep the
test-installcomman, but it will just print out some useful info and ensure all of the core submodules can be imported.There are a few places in our CI that actually use the
test-installcommand, so for now I think this is the easiest solution. And it's important to have a check like this so that we can catch certain errors like forgetting to include a library dependency insetup.py.