Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

ensure vision CI runs on each commit #4582

Merged
merged 3 commits into from
Aug 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
- vision
release:
types: [published]
schedule:
Expand Down Expand Up @@ -291,7 +292,7 @@ jobs:

- name: Upload master image
# Only run this for pushes to master on the main repo, not forks.
if: github.repository == 'allenai/allennlp' && github.event_name == 'push'
if: github.repository == 'allenai/allennlp' && github.event_name == 'push' && github.ref == 'refs/heads/master'
run: |
docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{ secrets.DOCKER_PASSWORD }}
docker push $DOCKER_IMAGE_NAME
Expand Down Expand Up @@ -422,9 +423,9 @@ jobs:
EOL

- name: Deploy docs
# Only run this on main repo (not forks) for commits and releases but not for
# nightly builds.
if: github.repository == 'allenai/allennlp' && github.event_name != 'schedule'
# Only run this on main repo (not forks) master branch for commits and releases,
# but not for nightly builds.
if: github.repository == 'allenai/allennlp' && github.event_name != 'schedule' && github.ref == 'refs/heads/master'
run: |
# And push them up to GitHub
cd ~/allennlp-docs/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
run: |
# If this step fails, this means you haven't updated the CHANGELOG.md
# file with notes on your contribution.
git diff --name-only $(git merge-base origin/master HEAD) | grep '^CHANGELOG.md$' && echo "Thanks for helping keep our CHANGELOG up-to-date!"
git diff --name-only $(git merge-base origin/${{ github.base_ref }} HEAD) | grep '^CHANGELOG.md$' && echo "Thanks for helping keep our CHANGELOG up-to-date!"

gpu_checks:
name: GPU Checks
Expand Down