Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

improve plugin section in README #4789

Merged
merged 3 commits into from
Nov 13, 2020
Merged

improve plugin section in README #4789

merged 3 commits into from
Nov 13, 2020

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Nov 12, 2020

Adds a table which lists both AI2 and third-party plugins 👇

image


@himkt let me know if you're okay with having your name in the README, or if you'd like me to use a different link. I'm just linking to your personal website right now.

@epwalsh epwalsh requested a review from schmmd November 12, 2020 18:44
@epwalsh
Copy link
Member Author

epwalsh commented Nov 12, 2020

@matt-gardner I also added allennlp-semparse to our default plugins. I'm not sure if there was a reason we didn't do that before?

Copy link
Contributor

@matt-gardner matt-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't think there was a particular reason to leave out semparse.

@himkt
Copy link
Contributor

himkt commented Nov 13, 2020

@epwalsh Thank you for mentioning me, it's an honor to me! (LGTM!)
The link is also good for me.

@epwalsh epwalsh merged commit e4cc95c into master Nov 13, 2020
@epwalsh epwalsh deleted the improve-plugin-docs branch November 13, 2020 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants