Always keep Spacy PoS tagger on #5066

leo-liuzy · 2021-03-24T16:44:30Z

Fixes #5036 .

Changes proposed in this pull request:

We always keep our spacy model's PoS tagger on, since the additional computation seems small and fix the behavioral issue of upgrading to SpaCy 3.0

allennlp/common/util.py

Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>

CHANGELOG.md

epwalsh

LGTM! Thanks @leo-liuzy!

leo-liuzy added 3 commits March 24, 2021 09:32

changing function signature of get_spacy_model

075aec6

add changelog

5ac8460

format files

7decfe6

leo-liuzy changed the title ~~Spacy tagger issue~~ Always keep Spacy PoS tagger on Mar 24, 2021

leo-liuzy added 2 commits March 24, 2021 10:25

fix SpacyTokenizer

7903d38

modify the change log

9d92ba0

leo-liuzy mentioned this pull request Mar 24, 2021

Always keep Spacy PoS tagger on allenai/allennlp-models#232

Closed

leo-liuzy added 3 commits March 24, 2021 11:45

change the function signature back (made a mistake)

efe5111

formatting

29abed4

change the function signature back (made a mistake)

bca7966

leo-liuzy requested a review from epwalsh March 24, 2021 19:18

Delete tbd.py

0d0caa5

epwalsh reviewed Mar 24, 2021

View reviewed changes

allennlp/common/util.py Outdated Show resolved Hide resolved

Leo Liu and others added 2 commits March 24, 2021 13:43

Update allennlp/common/util.py

361d8f9

Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>

change the function signature back (made a mistake)

5ef9f6f

leo-liuzy requested a review from epwalsh March 24, 2021 21:05

epwalsh reviewed Mar 24, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

9aa429d

epwalsh approved these changes Mar 24, 2021

View reviewed changes

epwalsh enabled auto-merge (squash) March 24, 2021 22:19

epwalsh merged commit 385124a into main Mar 24, 2021

epwalsh deleted the spacy-tagger-issue branch March 24, 2021 22:28

Provide feedback