This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Upload code coverage reports from different jobs, other CI improvements #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
changed the title
AkshitaB
reviewed
Jun 14, 2021
.github/workflows/ci.yml
Outdated
| mv coverage.xml coverage/ | ||
|
|
||
| - name: Save coverage report | ||
| if: matrix.python == '3.7' && github.repository == 'allenai/allennlp' && (github.event_name == 'push' || github.event_name == 'pull_request') |
There was a problem hiding this comment.
Oops, this was needed when these tests ran on multiple versions of Python, because we only needed one coverage report from this job.
dirkgr
reviewed
Jun 14, 2021
.github/workflows/ci.yml
Outdated
| pip freeze | ||
|
|
||
| - name: Run black | ||
| if: '! cancelled()' |
There was a problem hiding this comment.
Why is this check necessary? Doesn't it always cancel all the checks?
There was a problem hiding this comment.
This can be removed, it was only need when this check was in the other workflow that had a lot of different steps. And then it survived the copy-paste.
.github/workflows/ci.yml
Outdated
Comment on lines
140
to
142
| # Could run into issues with the cache if we don't uninstall the editable. | ||
| # See https://github.com/pypa/pip/issues/4537. | ||
| pip uninstall --yes allennlp |
There was a problem hiding this comment.
This reads like some hard-won wisdom.
.github/workflows/ci.yml
Outdated
Comment on lines
280
to
285
| - name: Debug info | ||
| run: | | ||
| ls -lh coverage | ||
| ls -lh coverage/cpu_tests | ||
| ls -lh coverage/gpu_tests | ||
| ls -lh coverage/model_tests |
There was a problem hiding this comment.
Probably not, I'll take out.
Co-authored-by: Akshita Bhagia <akshita23bhagia@gmail.com>
dirkgr
approved these changes
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5253. This gives us a more accurate code coverage report now, showing 91% covered instead of 88%.
This also makes a few other improvements to CI. Altogether, the changes proposed are:
setup-pythonaction to work on the self-hosted runner. But I was able to get it to work now by following this comment.flake8andmypychecks to a separate job calledLintblack --check .to a separate job calledStyle..bulldozer.ymlconfig which we don't use anymore.